Incursion (open source) 0.6.9Y4

[chooseusername]

An updated download is available on bitbucket.

The primary reason for this release is the tentative support for non-US keyboards, and ability to switch screen resolution/fullscreen/windowed at runtime.

Changes:

• Issue 39: Fix typo in cave entrance scripts, reported by Tuyen Tran.
• Issue 37: Fix bug where whips are unable to prevent enemies closing in with their reach, reported by Cranky_Corvids, fix provided by Carl Minden.
• Issue 38: Fix bug where when monsters died, they dropped their inventory.  But rather than clearing the flag on the item which marked the item as their property (and not something they could be ordered to give to the orderer), they cleared every other flag including as noted here the cursed flag.
• Issue 28: Extended knock spell description to refer to locked containers in general, and not just doors.
• Fix for resolution changing (via the options menu), and switching between full screen and windows (alt+enter).
• Preliminary fix for bug with some keyboards where people using non-US keyboard layouts find keys do not work as expected.  Please give feedback if this does not work for you, and how it is not working.

[Vanguard]

You're doing a great thing for the roguelike community.

[chooseusername]

You're doing a great thing for the roguelike community.

The Incursion source code is pretty well written, and easy to work with.  And Jice has been great at accepting my patches for libtcod.

[Krice]

The Incursion source code is pretty well written, and easy to work with.

..if you are a reptilian. Really? It's one of the worst source codes I have ever seen. Even worse than Crawl's original source code which at that time was feared, because it was so badly written and complicated.

[chooseusername]

The Incursion source code is pretty well written, and easy to work with.

..if you are a reptilian. Really? It's one of the worst source codes I have ever seen. Even worse than Crawl's original source code which at that time was feared, because it was so badly written and complicated.

Someday when you gain a few years of experience, you may see it differently.

[Krice]

Someday when you gain a few years of experience, you may see it differently.

In the other thread I already gave a list of wrong things in that source code and it wasn't even the complete list. Those bad practices are well known if you are anything else than a beginner level programmer, so I don't think you can give me that kind of advice.

[Zireael]

Grabbed. And I'm not commenting on the source code being tangled or not - at least the lib files are pretty readable and I can grab buckets of ideas (terrains, monsters, magic items, spells) for Veins.

[Zireael]

Hate to be a party pooper, but the non-US keyboard layout 'fix' made the space key register twice in options menu (issue #45).

EDIT : whoops, already reported and fixed, I wish there was a Y5 already

[getter77]

You're doing a great thing for the roguelike community.

Yep.

[chooseusername]

Someday when you gain a few years of experience, you may see it differently.

In the other thread I already gave a list of wrong things in that source code and it wasn't even the complete list. Those bad practices are well known if you are anything else than a beginner level programmer, so I don't think you can give me that kind of advice.

Your list was from my perspective subjective, and contained no points of relevance.  I find none of those things to be a real problem, and find the code base extremely easy to either upgrade or modify.  I consider some of them to be pluses.  As a point of comparison, I've worked on proprietary code bases which have been written with "good practices", which have been a bastard to work with and modify.

At the end of the day, regardless of any superficially identified problems, in practice it is a pleasure to work with the code and rather straightforward to.