Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
I downloaded head of master branch and played around a bit. Looks like a good start to me. I'm watching your repository at GitHub and will try to remember to check back when you have made more progress.Awesome, I'm glad to see someone taking some interest in the project! And yeah, a lot of the text in the design doc is placeholder stuff for ideas I haven't fully fleshed out quite yet. :p
I enjoyed reading through the design document and wouldn't mind visiting the dungeon of blah
I'm not really fond of using globals and try to avoid them as much as possible. But if you can keep track of what is changing what I guess that's just a personal preference.
The decision whether to split or not should generally be based on maintainability gain, not on file size.
The same thing happens in Visual Studio, as well as in Eclipse, and I think it's more an ill design than a bug. Certainly it makes the outlining feature completely useless, at least for me. It may be worth a notice that Eclipse has a window titled "Outline" which does similar job, but much better; it allows you to easily navigate through classes / methods / variables / imported declarations that you have in a single file, so that file size does not really matter [that much] any more.
It's a good idea to split code into smaller pieces. They are more manageable, easier to understand and faster to navigate.
Your idea of splitting the code looks sound. src_Classes sounds like a module that might end up being quite big though and quite generic. What would it contain?
I think what is important to understand is that while you can look at source organization as a code organization issue, in many ways it is just as much a tooling issue. What you may want to consider is changing (I hesitate to say 'improving' as that is quite subjective) your tooling to reflect your growing codebase.
For example, some editors let you have multiple views of a file and some do not. Some editors allow for an outline mode that lets you organize the source in a way completely different than the way the source is actually saved in files.
Did you changed the offset? Is it working now?
...Ultimately, if your levels are small and contain few objects, then you can probably get away with the current method - but if you expect features like breeding monsters, cloning items, rooms full of treasure, or bosses with lots of minions, then it might be worth considering this alternative method.
objects = {} objects['player'] = [player]
Though again, if this does what I think this does - takes a map location and searches every object in the game to find if there's an object blocking that tile, then I would suggest another solution. Iterating over every object in the game can be very expensive in all but the most simple games, so if you have a lot of objects it might be a good idea to have a mechanism of keeping track of which objects are contained in each location.
#now check for any blocking objects
for object in objects:
if object.blocks and object.x == x and object.y == y:
return True
That sounds like a good approach. My only concern is scalability - what happens if you or a modder make a particularly large number of items and you need to search a list by name for an item?I've never really used the dictionary/key setup before. How much faster would that make it?
The solution to that problem is either to sort the list by name and use binary search, or to put the items in a dictionary using names as keys.
def ReadItems(file):
if file is None: return 'No File'
filename = file + '.txt'
fyle = open(filename)
for lyne in fyle :
# read the line
# assign the variables
if lyne == ITEM_END_LINE:
#assign current variables to a new item
#create the item object
#add the item object to the Objects list
#reset variables
fyle.close()
def ReadFighters(file):
if file is None: return 'No File'
filename = file + '.txt'
fyle = open(filename)
for lyne in fyle :
# read the line
# assign the variables
if equipment:
for slots in equipment:
object_ThisFighter.equipment = GetEquipment(lyne)
if lyne == FIGHTER_END_LINE:
#assign current variables to a new fighter
#create the fighter object
#add the fighter object to the Objects list
#reset variables
fyle.close()
def GetEquipment(Name):
for Object in Objects:
if Object.name == Name:
return object
return None #or return Object_ErrorObject
def Main():
ReadItems('InfoFile')
ReadFighters('InfoFile')
def GetHead(self):
if self.ArmorHead:
return self.owner.name
else:
return 'Nothing'